search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
58 stars 118 forks source link

:seedling: Remove dnf config-manager after its use #526

Closed elfosardo closed 3 months ago

elfosardo commented 4 months ago

We don't really need it in the final image

tuminoid commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Ironic is built in e2e, so it is a good test (we don't have separate build test anymore)

elfosardo commented 4 months ago

/test metal3-centos-e2e-integration-test-main issue with CI ?

tuminoid commented 4 months ago

/test metal3-centos-e2e-integration-test-main issue with CI ?

Just a random network flake. It is amazing how they happen in such basic operations such as git clone or download a binary :(

elfosardo commented 4 months ago

/test metal3-ubuntu-e2e-integration-test-main

elfosardo commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid commented 4 months ago

I'm starting to think this has an effect on the failures (doesn't make sense tho), CI is quite stable otherwise....

elfosardo commented 4 months ago

I'm starting to think this has an effect on the failures (doesn't make sense tho), CI is quite stable otherwise....

I'll retest once more

elfosardo commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

elfosardo commented 4 months ago

@tuminoid this is really weird, the only thing I can think about is some dependencies being removed that are needed later I'm testing CI here https://github.com/metal3-io/ironic-image/pull/527 just to verify it

elfosardo commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

elfosardo commented 4 months ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

bash: line 1: minikube: command not found

elfosardo commented 4 months ago

/test metal3-centos-e2e-integration-test-main

dtantsur commented 4 months ago

/approve

metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iurygregory commented 3 months ago

/lgtm