metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🐛 Update httpd.conf.j2 #532

Closed owenthomas17 closed 1 month ago

owenthomas17 commented 1 month ago

What this PR does / why we need it: The current Listen directive does not work on systems that have ipv6 disabled. The Apache Listen directive supports Listen <port> syntax at which point it seems to be able to listen correctly on both dual stack and ipv4 only systems. See https://httpd.apache.org/docs/2.4/bind.html for more details.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #531

metal3-io-bot commented 1 month ago

Hi @owenthomas17. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mboukhalfa commented 1 month ago

/ok-to-test

mboukhalfa commented 1 month ago

Can you please sign the commit to fix the DCO ? and run tests ?

mboukhalfa commented 1 month ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

iurygregory commented 1 month ago

/lgtm issue in the job doesn't seem related

dtantsur commented 1 month ago

/approve

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mboukhalfa commented 1 month ago

failed because of http issue when installing packages /test metal3-ubuntu-e2e-integration-test-main

mboukhalfa commented 1 month ago

/lgtm

metal3-io-bot commented 1 month ago

@mboukhalfa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-image/pull/532#issuecomment-2245336541): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mboukhalfa commented 1 month ago

@iurygregory Can you please re-lgtm I do not have this permission on this repo ? cc @Rozzii

iurygregory commented 1 month ago

/lgtm