Closed owenthomas17 closed 1 month ago
Hi @owenthomas17. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Can you please sign the commit to fix the DCO ? and run tests ?
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/lgtm issue in the job doesn't seem related
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dtantsur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
failed because of http issue when installing packages /test metal3-ubuntu-e2e-integration-test-main
/lgtm
@mboukhalfa: adding LGTM is restricted to approvers and reviewers in OWNERS files.
@iurygregory Can you please re-lgtm I do not have this permission on this repo ? cc @Rozzii
/lgtm
What this PR does / why we need it: The current
Listen
directive does not work on systems that have ipv6 disabled. The Apache Listen directive supportsListen <port>
syntax at which point it seems to be able to listen correctly on both dual stack and ipv4 only systems. See https://httpd.apache.org/docs/2.4/bind.html for more details.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #531