metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

:warning: Update ipxe version #533

Closed elfosardo closed 1 month ago

elfosardo commented 1 month ago

This is a tentative to make ipxe more close to the current version and include some improvements and bug fixes. As a first step we build and install ipxe using a commit hash, as no stable versions have been released since December 2020.

We point the ipxe commit hash to [1] from November 2021, so roughly a year of changes is included. To see the complete list of changes run: git log --pretty=oneline 988d2c1..9062544 from a local clone of the ipxe repository.

In general the changes included between the stable 1.21.1 version and the current chosen hash improve compatibility with recent gcc and build libraries, while fixing numerous bugs.

This change also introduce a build arg to allow choosing the ipxe commit hash at container build time.

[1] https://github.com/ipxe/ipxe/commit/9062544f6a0c69c249b90d21a08d05518aafc2ec

elfosardo commented 1 month ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

elfosardo commented 1 month ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

dtantsur commented 1 month ago

/approve

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 1 month ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

elfosardo commented 1 month ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

iurygregory commented 1 month ago

/lgtm