metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🌱 Remove unused variable IRONIC_VMEDIA_SCHEME #534

Closed MahnoorAsghar closed 1 month ago

MahnoorAsghar commented 1 month ago

This variable is not used anywhere in ironic-image, ironic and baremetal-operator

MahnoorAsghar commented 1 month ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

elfosardo commented 1 month ago

/approve

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dtantsur commented 1 month ago

Indeed

/lgtm