metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🌱 Fix syntax in build images github workflow #539

Closed NymanRobin closed 3 weeks ago

NymanRobin commented 3 weeks ago

The syntax error in build images workflow caused all jobs to fail. These could probably be automatically caught in the future

NymanRobin commented 3 weeks ago

/cc @dtantsur @elfosardo @zaneb

tuminoid commented 3 weeks ago

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 3 weeks ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/ironic-image/pull/539#issuecomment-2296410400): >/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
elfosardo commented 3 weeks ago

/approve

metal3-io-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 1 week ago

/cherry-pick release-25.0

tuminoid commented 1 week ago

/cherry-pick release-24.1

tuminoid commented 1 week ago

/cherry-pick release-24.0

metal3-io-bot commented 1 week ago

@tuminoid: new pull request created: #553

In response to [this](https://github.com/metal3-io/ironic-image/pull/539#issuecomment-2331400783): >/cherry-pick release-25.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 week ago

@tuminoid: new pull request created: #554

In response to [this](https://github.com/metal3-io/ironic-image/pull/539#issuecomment-2331401424): >/cherry-pick release-24.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 week ago

@tuminoid: new pull request created: #555

In response to [this](https://github.com/metal3-io/ironic-image/pull/539#issuecomment-2331402527): >/cherry-pick release-24.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.