search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🐛Fix CPU burning on ironic-log-watch when no ramdisk file is present #548

Open blallau opened 2 weeks ago

blallau commented 2 weeks ago

Use inotifywait instead of an infinite loop.

Fixes #547

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign derekhiggins for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 2 weeks ago

Hi @blallau. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 1 week ago

We have https://github.com/metal3-io/ironic-image/pull/540 already addressing similar issue, can you collaborate on that PR?

tuminoid commented 1 week ago

/ok-to-test

tuminoid commented 1 week ago

Please fix shellcheck issues, preferably use curlys around variables as well, and when linting is green, trigger integration tests.

blallau commented 1 week ago

/retest

tuminoid commented 1 week ago

/retest

Retest won't run tests that are not run in the first place. /test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid commented 3 days ago

Can you rebase, so the fix we have merged is included. Otherwise CI won't work.

tuminoid commented 1 day ago

Can you rebase, so the fix we have merged is included. Otherwise CI won't work.

The official fix is in, so this should work now. /retest