metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
56 stars 116 forks source link

🐛SQLITE: fix Write-Ahead Log option and file permissions #550

Open blallau opened 2 weeks ago

blallau commented 2 weeks ago

sqlite Write-Ahead Log option and file permissions are set a a file named "ironic.db", but Ironic file used by Ironic is "ironic.sqlite" as bellow.

ironic-config/ironic.conf.j2: connection = sqlite:////var/lib/ironic/ironic.sqlite

Fixes #549

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign derekhiggins for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 2 weeks ago

Hi @blallau. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 1 week ago

/ok-to-test

tuminoid commented 1 week ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

blallau commented 1 week ago

@tuminoid CI fails on timeout :( Can we trigger it another time ?

tuminoid commented 1 week ago

You can just /retest or trigger it again with the same command I used.

/retest

tuminoid commented 1 week ago

OK, CI for centos should now be working.

/retest

blallau commented 1 week ago

/retest

tuminoid commented 1 week ago

/retest

Retest re-triggers failed tests only. All tests have passed, it just needs approvals now.

derekhiggins commented 1 week ago

/lgtm thanks

tuminoid commented 1 day ago

/cc @dtantsur @elfosardo