search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
58 stars 118 forks source link

:warning: Remove rpm install method #585

Closed elfosardo closed 3 weeks ago

elfosardo commented 3 weeks ago

Closes https://github.com/metal3-io/ironic-image/issues/583

elfosardo commented 3 weeks ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

elfosardo commented 3 weeks ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

elfosardo commented 3 weeks ago

@tuminoid thanks for the comments and suggestions, I didn't want to charge the PR too much so I just went for the minimum required changes, if that's ok for you I would apply your suggestions in a follow-up since it's passing CI

dtantsur commented 3 weeks ago

/approve

I agree with the comments. But since they concern the already existing code, I think it's a good idea to address them separately.

metal3-io-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 3 weeks ago

Follow up is ok as well.