🐛 improve upper constraints handling

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³

Apache License 2.0

58 stars 118 forks source link

🐛 improve upper constraints handling #590

Closed Rozzii closed 2 weeks ago

Rozzii commented 2 weeks ago

This commit:

Provides a default value for the UPPER_CONSTRAINT docker file argument
Changes the prepare-image.sh logic to check the actual size of the upper constraint file and not the presence of it.

Background of this change is that it has been noticed that on release branches during image building the "pinned" upper constraint file is not picked up rather pulled from upstream OpenStack because of a lack of default argument value during image building.

Rozzii commented 2 weeks ago

/cc @tuminoid @elfosardo

elfosardo commented 2 weeks ago

/approve

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/release-24.1/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment