search

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
5 stars 4 forks source link

Do not overwrite defaulted fields on the deployments #20

Closed dtantsur closed 5 months ago

dtantsur commented 5 months ago

Currently, the controllers are racing with the Deployment controller over the fields with defaults (like ImagePullPolicy). Only modify the fields we care about.

Finish the functional test to actually verify the deployment.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from dtantsur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-standalone-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment