search

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
5 stars 4 forks source link

🌱 add workflow to approve actions on PR change #30

Closed tuminoid closed 5 months ago

tuminoid commented 5 months ago

If external contributor adds a PR, and a member /ok-to-test it, GH actions do not run until approved by an approver. This approval needs to be given if the PR content changes, so it inconveniences the contributor but also the approver.

This PR approves workflows, if ok-to-test label is present.

Adapted from CAPI workflow: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml

Same as https://github.com/metal3-io/ip-address-manager/pull/485

/hold until IPAM workflow gets tested.

tuminoid commented 5 months ago

IPAM tested: https://github.com/metal3-io/ip-address-manager/pull/485#issuecomment-2042088493

/unhold

elfosardo commented 5 months ago

/lgtm

tuminoid commented 5 months ago

/assign @dtantsur

dtantsur commented 5 months ago

/approve

Thanks!

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-standalone-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment