search

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
6 stars 4 forks source link

:sparkles: allow Ironic to set nodeSelector #33

Closed matthewei closed 6 months ago

matthewei commented 6 months ago

sometime we want to config Ironic to be set up in a known node .

metal3-io-bot commented 6 months ago

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dtantsur commented 6 months ago

/ok-to-test

tuminoid commented 6 months ago

/retitle :sparkles: allow Ironic to set nodeSelector

Testing something that needs title edit.

matthewei commented 6 months ago

/retitle ✨ allow Ironic to set nodeSelector

Testing something that needs title edit.

I would like to add the e2e. But if we want to realize it. we should create at lease two nodes in a Cluster. But in this project I don't find it.

matthewei commented 6 months ago

I want to solve this function request #31

dtantsur commented 6 months ago

Could you please sign off DCO? E.g. git command -s --amend followed by git push -f?

matthewei commented 6 months ago

Could you please sign off DCO? E.g. git command -s --amend followed by git push -f?

yes, will do it.

matthewei commented 6 months ago

Could you please sign off DCO? E.g. git command -s --amend followed by git push -f?

yes, will do it.

Hi , How can I sign off DOC? I checked the commit info and have add it.

image

tuminoid commented 6 months ago

https://github.com/metal3-io/ironic-standalone-operator/pull/33/checks?check_run_id=24228940700

Commit sha: [cd3d523](https://github.com/metal3-io/ironic-standalone-operator/pull/33/commits/cd3d523426a6ee85efda5f1e48f73f3370172982), Author: shenwei, Committer: shenwei; Expected "shenwei [shenwei@cmss.chinamobile.com](mailto:shenwei@cmss.chinamobile.com)", but got "Matthew Shen [shenwei_yewu@cmss.chinamobile.com](mailto:shenwei_yewu@cmss.chinamobile.com)"

Your signed-off-by doesn't match your git committer.

dtantsur commented 6 months ago

/approve /lgtm

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-standalone-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment