Closed matthewei closed 6 months ago
Hi @matthewei. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/retitle :sparkles: allow Ironic to set nodeSelector
Testing something that needs title edit.
/retitle ✨ allow Ironic to set nodeSelector
Testing something that needs title edit.
I would like to add the e2e
. But if we want to realize it. we should create at lease two nodes in a Cluster. But in this project I don't find it.
I want to solve this function request #31
Could you please sign off DCO? E.g. git command -s --amend
followed by git push -f
?
Could you please sign off DCO? E.g.
git command -s --amend
followed bygit push -f
?
yes, will do it.
https://github.com/metal3-io/ironic-standalone-operator/pull/33/checks?check_run_id=24228940700
Commit sha: [cd3d523](https://github.com/metal3-io/ironic-standalone-operator/pull/33/commits/cd3d523426a6ee85efda5f1e48f73f3370172982), Author: shenwei, Committer: shenwei; Expected "shenwei [shenwei@cmss.chinamobile.com](mailto:shenwei@cmss.chinamobile.com)", but got "Matthew Shen [shenwei_yewu@cmss.chinamobile.com](mailto:shenwei_yewu@cmss.chinamobile.com)"
Your signed-off-by doesn't match your git committer.
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dtantsur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
sometime we want to config Ironic to be set up in a known node .