search

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
5 stars 4 forks source link

Error info isn't correct #34

Closed matthewei closed 3 months ago

matthewei commented 4 months ago

https://github.com/metal3-io/ironic-standalone-operator/blob/b24f9080bb33fa27d66c85885a16be826f5000ee/pkg/ironic/ironic.go#L146 I think a distributed deployment isn't correct and we can call a distributed daemonset

dtantsur commented 4 months ago

Here I'm using "deployment" in a wider sense, not in the sense of a Kubernetes resource. I think "distributed daemonset" may be confusing (and expose an implementation detailed), maybe "for distributed architecture"?

/triage accepted /help

metal3-io-bot commented 4 months ago

@dtantsur: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/metal3-io/ironic-standalone-operator/issues/34): >Here I'm using "deployment" in a wider sense, not in the sense of a Kubernetes resource. I think "distributed daemonset" may be confusing (and expose an implementation detailed), maybe "for distributed architecture"? > >/triage accepted >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
matthewei commented 4 months ago

Here I'm using "deployment" in a wider sense, not in the sense of a Kubernetes resource. I think "distributed daemonset" may be confusing (and expose an implementation detailed), maybe "for distributed architecture"?

/triage accepted /help

yes, the for distributed architecture is better.

matthewei commented 4 months ago

/assign

matthewei commented 3 months ago

/close

metal3-io-bot commented 3 months ago

@matthewei: Closing this issue.

In response to [this](https://github.com/metal3-io/ironic-standalone-operator/issues/34#issuecomment-2134775417): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.