metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
6 stars 4 forks source link

Modify the "Error info" when ironic is deployed in distributed architecture #36

Closed matthewei closed 5 months ago

matthewei commented 6 months ago

Modify the "Error info" when ironic is deployed in distributed architecture

metal3-io-bot commented 6 months ago

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dtantsur commented 5 months ago

/ok-to-test

@matthewei please remove the added .idea files

matthewei commented 5 months ago

/ok-to-test

@matthewei please remove the added .idea files

done

dtantsur commented 5 months ago

/approve /lgtm

Thanks!

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-standalone-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment