Ironic-pod contains ironic-auth volume but doesn't use it - Githubissues

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3

Apache License 2.0

6 stars 4 forks source link

Ironic-pod contains ironic-auth volume but doesn't use it #41

Closed matthewei closed 4 months ago

matthewei commented 5 months ago

Please check it.

metal3-io-bot commented 5 months ago

This issue is currently awaiting triage. If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dtantsur commented 5 months ago

It's actually used but only in the distributed case: https://github.com/metal3-io/ironic-standalone-operator/blob/main/pkg/ironic/containers.go#L242-L245 (for JSON RPC).

We will need its htpasswd part in all cases once there is some resolution for https://github.com/metal3-io/baremetal-operator/pull/1685

Rozzii commented 5 months ago

Just adding here the ironic-image related PR https://github.com/metal3-io/ironic-image/pull/506

matthewei commented 4 months ago

yes, I see.

Rozzii commented 4 months ago

@matthewei can we close this issue?

matthewei commented 4 months ago

/close

matthewei commented 4 months ago

@matthewei can we close this issue?

yes, why not