Closed dtantsur closed 3 months ago
/assign @tuminoid
Could you make sure I'm not undoing any of your security fixes?
/assign @tuminoid
Could you make sure I'm not undoing any of your security fixes?
You should be bumping to Go 1.22.3, 1.22.2 has 3 vulnerabilities open. Otherwise the tree is clean. :+1:
@tuminoid done as you suggested
@tuminoid looks like github actions only have 1.22.2 on their ubuntu runners :(
@tuminoid looks like github actions only have 1.22.2 on their ubuntu runners :(
Yeah, let me take a look, if we can fix that. We have other repos working fine, so I think we need to add the go-setup step here as well.
We also need to merge this for the gomod to pass: https://github.com/metal3-io/project-infra/pull/783
@tuminoid looks like github actions only have 1.22.2 on their ubuntu runners :(
Yeah, let me take a look, if we can fix that. We have other repos working fine, so I think we need to add the go-setup step here as well.
We also need to merge this for the gomod to pass: metal3-io/project-infra#783
OK, so if we merge #43 and then rebase this, and also merge the project-infra PR for the gomod test, then I think this should pass.
Also edit hack/gomod.sh
to run Go 1.22 (fixes local runs).
/test gomod
@tuminoid: adding LGTM is restricted to approvers and reviewers in OWNERS files.
It was about dependencies initially, Go is sort of forced on me :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dtantsur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@tuminoid: adding LGTM is restricted to approvers and reviewers in OWNERS files.
Indeed: https://github.com/metal3-io/ironic-standalone-operator/pull/44
We're about to pick up active development here again, let's make sure to work with the latest stuff to avoid accidentally depending on old and incompatible versions (looking at you, controller-runtime).
Forces bumping the Go version to 1.22 (using 1.22.2 to avoid reverting the fix for https://osv.dev/vulnerability/GO-2024-2687).