search

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
6 stars 4 forks source link

Determine whether initcontainer is needed through IPAConfig options #45

Open matthewei opened 4 months ago

matthewei commented 4 months ago

Some times we can build a http server out of cluster and we can also ues it to be as a image-server. And we can upload kernal and ramdisk into it. So I think we may don't need the init-Pod in Ironic's Pod.

I have modified the Ironic CRD

apiVersion: metal3.io/v1alpha1
kind: Ironic
metadata:
  name: ironic-server
spec:
  images:
    ipaConfig:
      ipaEnabled: true
      ironic: registry.paas/metal3-io/ironic:v1.0
      ramdiskDownloader: registry.paas/metal3-io/ipa-config:v17
metal3-io-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/ironic-standalone-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 4 months ago

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
matthewei commented 4 months ago

@dhellmann Hi , Could you have a look my code.

metal3-io-bot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.