search

metal3-io / ironic-standalone-operator

WIP Operator to maintain an Ironic deployment for Metal3
Apache License 2.0
5 stars 4 forks source link

Rework handling of images and versions #47

Closed dtantsur closed 1 month ago

dtantsur commented 1 month ago

User-supplied images via CRD's goes against operator best practices and make upgrades very complicated. Remove the Images structure but allow for downstream customizations via CLI flags and environment variables.

Record the version that was installed to use it in upgrade logic.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

elfosardo commented 1 month ago

/lgtm

dtantsur commented 1 month ago

/approve

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-standalone-operator/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment