search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
112 stars 118 forks source link

bump shellcheck to v0.10.0 #1362

Closed tuminoid closed 6 months ago

tuminoid commented 6 months ago

Shellcheck had its first release since 2022, so bump it.

tuminoid commented 6 months ago

/hold needs project-infra change as well.

kashifest commented 6 months ago

/approve

tuminoid commented 6 months ago

/unhold Project-infra has gone in. /test shellcheck

/override test-centos-integration-release-1-6 test-ubuntu-integration-main

metal3-io-bot commented 6 months ago

@tuminoid: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1362#issuecomment-1985666938): >/unhold >Project-infra has gone in. >/test shellcheck > >/override test-centos-integration-release-1-6 test-ubuntu-integration-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 6 months ago

/override test-centos-integration-release-1-6 test-ubuntu-e2e-integration-main

metal3-io-bot commented 6 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-integration-release-1-6, test-ubuntu-e2e-integration-main

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1362#issuecomment-1985667519): >/override test-centos-integration-release-1-6 test-ubuntu-e2e-integration-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [kashifest,smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment