search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
109 stars 117 forks source link

Use GOPROXY to get latest releases instead of git APIs #1376

Open adilGhaffarDev opened 3 months ago

adilGhaffarDev commented 3 months ago

Problem

Here: https://github.com/metal3-io/metal3-dev-env/blob/04b45cd49bf52e81f1db8d241ff51a5791c6f344/lib/releases.sh#L3 We are using git api to get the latest releases, if git API is used multiple times without GITHUB_TOKEN we start getting following error:

rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable

Solution

Instead of using git APIs we should use GOPROXY. In this way we will not need GITHUB_TOKEN and we will also get rid of rate limit error.

Below are GOPROXY links that list out all releases:

Write a function that get latest release from GOPROXY links and use that to get latest releases

/good-first-issue

metal3-io-bot commented 3 months ago

@adilGhaffarDev: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/metal3-io/metal3-dev-env/issues/1376): >### Problem >Here: >https://github.com/metal3-io/metal3-dev-env/blob/04b45cd49bf52e81f1db8d241ff51a5791c6f344/lib/releases.sh#L3 >We are using git api to get the latest releases, if git API is used multiple times without `GITHUB_TOKEN` we start getting following error: > >`rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable` > >### Solution: >Instead of using git APIs we should use GOPROXY. In this way we will not need `GITHUB_TOKEN` and we will also get rid of rate limit error. > >Below are GOPROXY links that list out all releases: > >- CAPI: https://proxy.golang.org/sigs.k8s.io/cluster-api/@v/list >- CAPM3: https://proxy.golang.org/github.com/metal3-io/cluster-api-provider-metal3/@v/list > > > >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
adilGhaffarDev commented 3 months ago

/triage accepted

metal3-io-bot commented 23 hours ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale