"make" doesn't check if all containers are Ready

metal3-io / metal3-dev-env

Metal³ Development Environment

Apache License 2.0

111 stars 118 forks source link

"make" doesn't check if all containers are Ready #1377

Open tuminoid opened 4 months ago

tuminoid commented 4 months ago

If a container fails readiness check, say Ironic, and shows 4/5 in kubectl get pods -A, make doesn't wait for that, and just returns with Success. Then integration test runs make test . After pivoting to target cluster, "make test" DOES check if everything is Ready. This is misleading as the installation was effectively broken way earlier than pivot.

Solution is to make ansible wait for source cluster to be ready before moving on.

/kind bug

tuminoid commented 4 months ago

/triage accepted

metal3-io-bot commented 1 month ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Rozzii commented 1 month ago

/remove-lifecycle stale