metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

Test new node image built with DIB #1384

Closed NymanRobin closed 7 months ago

NymanRobin commented 7 months ago

This PR is mainly meant to test the new image built with Disk Image builder in this PR: #679

metal3-io-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign smoshiur1237 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Sunnatillo commented 7 months ago

/test-centos-integration-release-1-6 /test-ubuntu-e2e-integration-main

NymanRobin commented 7 months ago

Thanks @Sunnatillo for running the tests, but seems like I missed this comment # Kubectl version (do not forget to update KUBECTL_SHA256 when changing KUBERNETES_VERSION!)

But maybe just hard coding the image directly would work, but I will check this in a bit more detail if you do not already know?

Sunnatillo commented 7 months ago

Lets run this on project infra and manually set all the vars there.

NymanRobin commented 7 months ago

/test-centos-integration-release-1-6 /test-ubuntu-e2e-integration-main

metal3-io-bot commented 7 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
NymanRobin commented 7 months ago

This can be closed as the changes are done already in #1389