search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
109 stars 117 forks source link

There is conflicting rpm packages add --nobest flag #1396

Closed NymanRobin closed 1 month ago

NymanRobin commented 1 month ago

This flag ignores updating packages to the newest that are conflicting. This allows running dev-env even when some pakcages might be conflicting as this is not directly in our control.

This is related to this issue: https://github.com/metal3-io/project-infra/issues/738

Hopefully this would fix this issue to get the tests passing again

NymanRobin commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-7

NymanRobin commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-7

NymanRobin commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-7

Sunnatillo commented 1 month ago

/test ?

metal3-io-bot commented 1 month ago

@Sunnatillo: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1396#issuecomment-2100042606): >/test ? > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Sunnatillo commented 1 month ago

/test metal3-dev-env-integration-test-centos-main

NymanRobin commented 1 month ago

/test metal3-dev-env-integration-test-centos-main

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
smoshiur1237 commented 1 month ago

/override metal3-ubuntu-e2e-integration-test-main

metal3-io-bot commented 1 month ago

@smoshiur1237: Overrode contexts on behalf of smoshiur1237: metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1396#issuecomment-2100268307): >/override metal3-ubuntu-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Rozzii commented 1 month ago

If I run dev-env with this patch on a vanilla Centos VM the selinux ansible task fails But I think this PR by itself is good to go! /lgtm 

                                                                                                                                                                                                             │
TASK [packages_installation : Enable SELinux] **********************************                                                                                                                                   │
task path: /home/adam/nordix/metal3-dev-env/vm-setup/roles/packages_installation/tasks/centos_required_packages.yml:7                                                                                              │
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Policy targeted does not exist in /etc/selinux/"}
smoshiur1237 commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-7

Sunnatillo commented 1 month ago

/assign @tuminoid @kashifest @Rozzii Please override failing test. The issue is not related to this PR change. lets get merge this PR.

smoshiur1237 commented 1 month ago

/override metal3-centos-e2e-integration-test-release-1-7

metal3-io-bot commented 1 month ago

@smoshiur1237: Overrode contexts on behalf of smoshiur1237: metal3-centos-e2e-integration-test-release-1-7

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1396#issuecomment-2100499796): >/override metal3-centos-e2e-integration-test-release-1-7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.