search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
109 stars 117 forks source link

shellcheck only files #1410

Closed tuminoid closed 1 month ago

tuminoid commented 1 month ago

Make shellcheck consider only files.

If branch name ended with .sh or .sh/something, it was found on the filesystem as something ending with .sh, and shellcheck picked it up, and linting failed obviously.

tuminoid commented 1 month ago

/override metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

metal3-io-bot commented 1 month ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-7, metal3-dev-env-integration-test-ubuntu-main

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1410#issuecomment-2139467142): >/override metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 1 month ago

/cc @Sunnatillo @kashifest

kashifest commented 1 month ago

/approve

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment