metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
109 stars 117 forks source link

tie BMO commits for CAPM3RELEASEBRANCH variables #1415

Closed Rozzii closed 3 weeks ago

Rozzii commented 3 weeks ago

This commit:

The reason is that in case BMO release branch HEAD is used together with a specific BMO container image release tag in the same deployment, there is a chance that a e.g. some patch could introduce CRD misalignment between the unchanged container image and the moving release branch head thus causing BMO operations or even BMO bootstrapping to fail.

Rozzii commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-7 /test metal3-dev-env-integration-test-ubuntu-main

tuminoid commented 3 weeks ago

Alternatively, we could use release-0.x tag of the container image and Git branch both?

Rozzii commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-7 /test metal3-dev-env-integration-test-ubuntu-main

Rozzii commented 3 weeks ago

Alternatively, we could use release-0.x tag of the container image and Git branch both?

In capm3 e2e we could overwrite these as that is a test / ci use-case , but in dev-env imo the idea is to deploy the supported releases by default so in dev-env I would go the way I did.

Rozzii commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-7 /test metal3-dev-env-integration-test-ubuntu-main

metal3-io-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Rozzii commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-7 /test metal3-dev-env-integration-test-ubuntu-main

Rozzii commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-7