search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

Install ansible in a virtual environment #1419

Closed dtantsur closed 5 months ago

dtantsur commented 5 months ago

Installing packages globally with pip is not recommended since such packages may conflict with the system. Using a virtual environment is the approach we have employed in Bifrost for a long time, let's do the same here.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 5 months ago

/test metal3-dev-env-integration-test-ubuntu-main

dtantsur commented 5 months ago

/test metal3-dev-env-integration-test-ubuntu-main

tuminoid commented 5 months ago

/test metal3-dev-env-integration-test-centos-main Python installations are somewhat different, so let's run centos as well.

dtantsur commented 5 months ago

Python installations are somewhat different, so let's run centos as well.

Yeah, I wanted one job to pass before I occupy the CI with the rest :)

tuminoid commented 5 months ago

Python installations are somewhat different, so let's run centos as well.

Yeah, I wanted one job to pass before I occupy the CI with the rest :)

Ubuntu progressed, so ... :)

Centos will probably fail tho, there seems to be again some issue with the new cloud + Centos, but it'll probably pass far enough to tell if venv worked or not.

dtantsur commented 5 months ago

/test metal3-centos-e2e-integration-test-release-1-7

tuminoid commented 5 months ago

Don't bother with Centos right now, we're debugging Centos main as all centos e2e are failing now, as VMs are not coming up and hence BMHs are not ever inspected.

tuminoid commented 5 months ago

/override metal3-dev-env-integration-test-centos-main Not required even, skip.

metal3-io-bot commented 5 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-dev-env-integration-test-centos-main

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1419#issuecomment-2165255588): >/override metal3-dev-env-integration-test-centos-main >Not required even, skip. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mboukhalfa commented 5 months ago

/approve

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [mboukhalfa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment