search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
109 stars 117 forks source link

Install go 1.21.x for release-1.5 branch #1423

Closed kashifest closed 3 weeks ago

kashifest commented 3 weeks ago

This PR installs go1.21.x for release-1.5 branch. For other branches it should install 1.22.x. This is for the fact that CAPM3 release-1.5 branch wont survive go 1.22 because of version incompatability with controller runtime. Signed-off-by: Kashif Khan kashif.khan@est.tech

kashifest commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-release-1.5 /test metal3-centos-e2e-integration-test-release-1-5

kashifest commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-release-1-5

kashifest commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-release-1.5

metal3-io-bot commented 3 weeks ago

@kashifest: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1423#issuecomment-2167359762): >/test metal3-dev-env-integration-test-ubuntu-release-1.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kashifest commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-release-1-5

kashifest commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-release-1-5

kashifest commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-5

kashifest commented 3 weeks ago

/test metal3-e2e-clusterctl-upgrade-test-release-1-5

kashifest commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-release-1-5 /test metal3-dev-env-integration-test-ubuntu-main /test metal3-centos-e2e-integration-test-release-1-7

kashifest commented 3 weeks ago

Maybe add a comment here why its like this, but otherwise seem that this is passing and fixing all 1.5 jobs.

I have added in the description, do you mean thats not enough ?

tuminoid commented 3 weeks ago

Maybe add a comment here why its like this, but otherwise seem that this is passing and fixing all 1.5 jobs.

I have added in the description, do you mean thats not enough ?

That was supposed to be a comment on the code change, ie. include comment in the ansible file.

kashifest commented 3 weeks ago

That was supposed to be a comment on the code change, ie. include comment in the ansible file.

Ah, no I guess its fine, commit message has that as well, I dont want to hamper the running tests now, once the test pass, I can push a change and then override the tests if you want, IMO its not needed.

kashifest commented 3 weeks ago

@adilGhaffarDev is the failure in the clusterctl test now related to what you are fixing in ironic upgrade ?

STEP: Waiting for ironic update to rollout @ 06/14/24 08:49:50.134
12:00:02    [FAILED] in [It] - /home/metal3ci/metal3/test/e2e/upgrade_ironic.go:61 @ 06/14/24 08:59:50.147
12:00:02    < Exit [It] Should create a management cluster and then upgrade all the providers @ 06/14/24 08:59:50.149 (40m31.701s)
adilGhaffarDev commented 3 weeks ago

@adilGhaffarDev is the failure in the clusterctl test now related to what you are fixing in ironic upgrade ?

this is a known issue clusterctl upgrade tests on the 1.5 branch, fix is in progress.

kashifest commented 3 weeks ago

/override metal3-e2e-clusterctl-upgrade-test-release-1-5

@adilGhaffarDev confirmed that the error we see now is unrelated , known issue and being worked upon separately. However, since the test reached this far shows that the fix is working.

metal3-io-bot commented 3 weeks ago

@kashifest: Overrode contexts on behalf of kashifest: metal3-e2e-clusterctl-upgrade-test-release-1-5

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1423#issuecomment-2167839509): >/override metal3-e2e-clusterctl-upgrade-test-release-1-5 > >@adilGhaffarDev confirmed that the error we see now is unrelated , known issue and being worked upon separately. However, since the test reached this far shows that the fix is working. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 3 weeks ago

I have also verified the go versions in the different branch tests, if you simple search for go env in the jenkins log you will find that for release-1.5 branch it is go1.21.11 whereas for other branches it is go1.22.4 as expected