search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
109 stars 117 forks source link

Always re-install Ansible in the venv #1426

Closed dtantsur closed 2 weeks ago

dtantsur commented 2 weeks ago

Currently, if the system site packages already have ansible, it won't be installed, causing a failure because of missing ansible-galaxy. Force installation in the venv even if the system package is present.

Also wipe the virtual environment if it's already present.

Fixes: #1425

tuminoid commented 2 weeks ago

Moved the fixes to description where it is expected for auto closing.

tuminoid commented 2 weeks ago

/test ?

metal3-io-bot commented 2 weeks ago

@tuminoid: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1426#issuecomment-2172543898): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 weeks ago

/test-integration-bml-centos

tuminoid commented 2 weeks ago

@Sunnatillo how can we run BML e2e in this PR?

dtantsur commented 2 weeks ago

Moved the fixes to description where it is expected for auto closing.

I believe it would work in the title, but this is fine too.

tuminoid commented 2 weeks ago

Moved the fixes to description where it is expected for auto closing.

I believe it would work in the title, but this is fine too.

I did not see it in the right side panel tho, and also we have (in some other repos) PR verifier workflows that verify there is no issue ids in the title.

tuminoid commented 2 weeks ago

/test metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

tuminoid commented 2 weeks ago

@Sunnatillo how can we run BML e2e in this PR?

OK; it got accidentally removed from Prow config, @Sunnatillo will put it back and then we can run it here.

tuminoid commented 2 weeks ago

Project-infra PR here: https://github.com/metal3-io/project-infra/pull/792

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment