search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
112 stars 118 forks source link

Use Python from the Ansible venv when importing Jinja2 #1427

Closed dtantsur closed 3 months ago

dtantsur commented 3 months ago

Nothing installs Jinja2, we just expect Ansible to pull it in. Now that Ansible is installed in a venv, use Jinja2 from there.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

tuminoid commented 3 months ago

Might also need to fix lib/network.sh lines 16, 27, and 67 to get correct python used, even if those lines do not explode right now.

tuminoid commented 3 months ago

Might also need to fix lib/network.sh lines 16, 27, and 67 to get correct python used, even if those lines do not explode right now.

L67 call is prior setting up venv, so it would not even work actually. Let's skip, module is standard anyways.

tuminoid commented 3 months ago

/test metal3-dev-env-integration-test-ubuntu-main metal3-dev-env-integration-test-centos-main

elfosardo commented 3 months ago

/approve

dtantsur commented 3 months ago

/test metal3-centos-e2e-integration-test-release-1-7

tuminoid commented 3 months ago

/override metal3-centos-e2e-integration-test-release-1-7 /test metal3-dev-env-integration-test-centos-main

metal3-io-bot commented 3 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-7

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1427#issuecomment-2175013412): >/override metal3-centos-e2e-integration-test-release-1-7 >/test metal3-dev-env-integration-test-centos-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 3 months ago

/Cc @smoshiur1237

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment