search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

🌱 bump k8s to v1.31.0 #1444

Closed adilGhaffarDev closed 3 months ago

adilGhaffarDev commented 3 months ago
metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 3 months ago

/test metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

adilGhaffarDev commented 3 months ago

we don't have 1.31 image on artifactory yet that's why it's failing.

tuminoid commented 3 months ago

we don't have 1.31 image on artifactory yet that's why it's failing.

Where does the image come from? Manual?

adilGhaffarDev commented 3 months ago

Where does the image come from? Manual?

jenkins job should push it, but seems like it didn't work, @Sunnatillo has pushed them manually.

adilGhaffarDev commented 3 months ago

/test metal3-centos-e2e-integration-test-release-1-7 metal3-dev-env-integration-test-ubuntu-main

Sunnatillo commented 3 months ago

Can you update renovate.json as well like in here? https://github.com/Nordix/metal3-dev-env/commit/f7c2c40dff51c6076e66a2023e8b0e57e9dcbb1b#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57

Lets wait for the tests to pass before doing the change. We can just override them.

adilGhaffarDev commented 3 months ago

/unhold

adilGhaffarDev commented 3 months ago

Can you update renovate.json as well like in here? Nordix@f7c2c40#diff-7b5c8955fc544a11b4b74eddb4115f9cc51c9cf162dbffa60d37eeed82a55a57

done

Sunnatillo commented 3 months ago

/override metal3-centos-e2e-integration-test-release-1-7 /override metal3-dev-env-integration-test-ubuntu-main

metal3-io-bot commented 3 months ago

@Sunnatillo: Sunnatillo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1444#issuecomment-2290864887): >/override metal3-centos-e2e-integration-test-release-1-7 >/override metal3-dev-env-integration-test-ubuntu-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 3 months ago

/override metal3-centos-e2e-integration-test-release-1-7 /override metal3-dev-env-integration-test-ubuntu-main

Per comment above, only renovate was changed after tests had passed.

metal3-io-bot commented 3 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-7, metal3-dev-env-integration-test-ubuntu-main

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1444#issuecomment-2290871959): >/override metal3-centos-e2e-integration-test-release-1-7 >/override metal3-dev-env-integration-test-ubuntu-main > >Per comment above, only renovate was changed after tests had passed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.