metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

:seedling: Add cleaning up fake-ipa container to make clean #1469

Closed mquhuy closed 2 weeks ago

mquhuy commented 2 weeks ago

fake-ipa container might have been started by make, it should be cleaned properly in make clean.

metal3-io-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mquhuy commented 2 weeks ago

/cc @lentzi90 @Rozzii

tuminoid commented 2 weeks ago

/test all

tuminoid commented 2 weeks ago

/override metal3-centos-e2e-integration-test-release-1-8
/test metal3-dev-env-integration-test-ubuntu-main

metal3-io-bot commented 2 weeks ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-8

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1469#issuecomment-2467333849): >/override metal3-centos-e2e-integration-test-release-1-8 >/test metal3-dev-env-integration-test-ubuntu-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 weeks ago

/lgtm

Prow missed this. /lgtm

Rozzii commented 2 weeks ago

/retest

tuminoid commented 2 weeks ago

Prow has issues with Xerces.

Rozzii commented 2 weeks ago

Issue supposed to be sorted out, let's see... /retest

Rozzii commented 2 weeks ago

/retest