Closed tuminoid closed 1 month ago
/hold until there is also a fix PR.
@smoshiur1237: adding LGTM is restricted to approvers and reviewers in OWNERS files.
/lgtm
@tuminoid is there an example run of this somewhere (possibly fork)?
There is specific if:
in the workflow to prevent it from running on forks, but you can run it with gh
CLI using extension act
for example. It fails 10-12 URLs right now, which is why I held it. I'm working on PR to fix those links before we can merge this.
There is specific
if:
in the workflow to prevent it from running on forks, but you can run it withgh
CLI using extensionact
for example. It fails 10-12 URLs right now, which is why I held it. I'm working on PR to fix those links before we can merge this.
Used act
before, cool stuff. In any case this should be good to go IMO.
/approve
New changes are detected. LGTM label has been removed.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: furkatgofurov7, smoshiur1237
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: furkatgofurov7, smoshiur1237
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: furkatgofurov7, smoshiur1237
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Current status with broken links:
+ find . -name '*.md' -not -path './node_modules/*' -exec markdown-link-check '{}' --config .markdownlinkcheck.json -q ';'
| + set +x
| =========================> MARKDOWN LINK CHECK <=========================
|
| FILE: ./docs/presentations/README.md
|
| 4 links checked.
|
| FILE: ./docs/README.md
|
| 2 links checked.
|
| FILE: ./docs/prerequisites.md
|
| 0 links checked.
|
| FILE: ./docs/user-guide/README.md
|
| 5 links checked.
|
| FILE: ./docs/user-guide/src/introduction.md
|
| 7 links checked.
|
| FILE: ./docs/user-guide/src/ipam/ipam_installation.md
|
| 4 links checked.
|
| FILE: ./docs/user-guide/src/ipam/introduction.md
|
| 1 links checked.
|
| FILE: ./docs/user-guide/src/version_support.md
|
| 1 links checked.
|
| FILE: ./docs/user-guide/src/security_policy.md
|
| 4 links checked.
|
| FILE: ./docs/user-guide/src/flake/introduction.md
|
| 0 links checked.
|
| FILE: ./docs/user-guide/src/flake/bmh_stuck.md
| [✖] https://opendev.org/openstack/ironic/src/commit/eeeaa274cfc7ebee52beaed97571e2f87127f2dd/ironic/db/sqlalchemy/api.py#L2056
|
| 3 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://opendev.org/openstack/ironic/src/commit/eeeaa274cfc7ebee52beaed97571e2f87127f2dd/ironic/db/sqlalchemy/api.py#L2056 → Status: 0
|
| FILE: ./docs/user-guide/src/flake/calico_manifest_download.md
|
| 1 links checked.
|
| FILE: ./docs/user-guide/src/flake/floating_ip_error.md
|
| 0 links checked.
|
| FILE: ./docs/user-guide/src/flake/prow.md
|
| 1 links checked.
|
| FILE: ./docs/user-guide/src/flake/nordix_timeout.md
|
| 3 links checked.
|
| FILE: ./docs/user-guide/src/SUMMARY.md
|
| 31 links checked.
|
| FILE: ./docs/user-guide/src/ironic/ironic_installation.md
|
| 4 links checked.
|
| FILE: ./docs/user-guide/src/ironic/introduction.md
|
| 9 links checked.
|
| FILE: ./docs/user-guide/src/ironic/ironic_variables.md
|
| 0 links checked.
|
| FILE: ./docs/user-guide/src/ironic/ironic-container-images.md
|
| 5 links checked.
|
| FILE: ./docs/user-guide/src/ironic/ironic-python-agent.md
|
| 5 links checked.
|
| FILE: ./docs/user-guide/src/capm3/node_reuse.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/capm3/introduction.md
|
| 14 links checked.
|
| FILE: ./docs/user-guide/src/capm3/remediaton.md
|
| 3 links checked.
|
| FILE: ./docs/user-guide/src/capm3/installation_guide.md
| [✖] TODO
|
| 4 links checked.
|
| ERROR: 1 dead links found!
| [✖] TODO → Status: 400
|
| FILE: ./docs/user-guide/src/capm3/automated_cleaning.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/capm3/pivoting.md
|
| 4 links checked.
|
| FILE: ./docs/user-guide/src/bmo/automatic_secure_boot.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/bmo/reboot_annotation.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/bmo/detached_annotation.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/bmo/introduction.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/bmo/status_annotation.md
|
| 1 links checked.
|
| FILE: ./docs/user-guide/src/bmo/automated_cleaning.md
|
| 3 links checked.
|
| FILE: ./docs/user-guide/src/bmo/external_inspection.md
|
| 1 links checked.
|
| FILE: ./docs/user-guide/src/bmo/live-iso.md
|
| 2 links checked.
|
| FILE: ./docs/user-guide/src/bmo/inspect_annotation.md
|
| 1 links checked.
|
| FILE: ./design/_template.md
| [✖] /designs/_template.md
|
| 2 links checked.
|
| ERROR: 1 dead links found!
| [✖] /designs/_template.md → Status: 400
|
| FILE: ./design/baremetal-operator/host-config-drive.md
|
| 3 links checked.
|
| FILE: ./design/baremetal-operator/managing-provisioning-dependencies.md
|
| 1 links checked.
|
| FILE: ./design/baremetal-operator/annotation-for-power-cycling-and-deleting-failed-nodes.md
|
| 5 links checked.
|
| FILE: ./design/baremetal-operator/bmo-part-of-capm3.md
|
| 1 links checked.
|
| FILE: ./design/baremetal-operator/reboot-interface.md
|
| 0 links checked.
|
| FILE: ./design/baremetal-operator/bmc-events.md
| [✖] https://www.dell.com/support/manuals/en-jm/idrac9-lifecycle-controller-v4.x-series/idrac9_4.00.00.00_redfishapiguide_pub/temperature?guid=guid-5a798111-407b-485d-b6fb-7d6e367d4ad4&lang=en-us
|
| 7 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://www.dell.com/support/manuals/en-jm/idrac9-lifecycle-controller-v4.x-series/idrac9_4.00.00.00_redfishapiguide_pub/temperature?guid=guid-5a798111-407b-485d-b6fb-7d6e367d4ad4&lang=en-us → Status: 403
|
| FILE: ./design/baremetal-operator/explicit-boot-mode.md
|
| 4 links checked.
|
| FILE: ./design/baremetal-operator/bulk-set-bios-config.md
|
| 7 links checked.
|
| FILE: ./design/baremetal-operator/sub-states.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/hardwaredata_crd.md
|
| 13 links checked.
|
| FILE: ./design/baremetal-operator/bmc-address.md
|
| 1 links checked.
|
| FILE: ./design/baremetal-operator/raid-disk-controller.md
|
| 0 links checked.
|
| FILE: ./design/baremetal-operator/bmh_live_iso.md
|
| 6 links checked.
|
| FILE: ./design/baremetal-operator/deploy-steps.md
|
| 6 links checked.
|
| FILE: ./design/baremetal-operator/kubebuilder-migration.md
| [✖] https://sdk.operatorframework.io/docs/building-operators/golang/project_migration_guide/
|
| 16 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://sdk.operatorframework.io/docs/building-operators/golang/project_migration_guide/ → Status: 404
|
| FILE: ./design/baremetal-operator/limit-hosts-provisioning.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/external-introspection.md
|
| 6 links checked.
|
| FILE: ./design/baremetal-operator/how-ironic-works.md
|
| 6 links checked.
|
| FILE: ./design/baremetal-operator/secure-boot.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/image-builder-integration.md
|
| 3 links checked.
|
| FILE: ./design/baremetal-operator/user-defined-root-device-hints.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/remove-host.md
|
| 0 links checked.
|
| FILE: ./design/baremetal-operator/unmanaged-state.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/raid-api.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/inspection-api.md
|
| 2 links checked.
|
| FILE: ./design/baremetal-operator/implicit-boot-mode.md
| [✖] https://github.com/metal3-io/baremetal-operator/blob/main/pkg/bmc/access.go#L27
|
| 8 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://github.com/metal3-io/baremetal-operator/blob/main/pkg/bmc/access.go#L27 → Status: 404
|
| FILE: ./design/baremetal-operator/hardware-status.md
|
| 6 links checked.
|
| FILE: ./design/baremetal-operator/detached-annotation.md
|
| 4 links checked.
|
| FILE: ./design/baremetal-operator/bios-config.md
|
| 3 links checked.
|
| FILE: ./design/helm-charts/single-pod-helm-chart.md
|
| 0 links checked.
|
| FILE: ./design/image-ownership.md
|
| 0 links checked.
|
| FILE: ./design/api-design-principles.md
|
| 1 links checked.
|
| FILE: ./design/physical-network-api-prototype.md
|
| 8 links checked.
|
| FILE: ./design/ip-address-manager/ip-address-management-for-networkdata.md
|
| 23 links checked.
|
| FILE: ./design/nodes-machines-and-hosts.md
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html
|
| 8 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html → Status: 404
|
| FILE: ./design/metadata-handling.md
|
| 3 links checked.
|
| FILE: ./design/fd-support-kcp.md
|
| 7 links checked.
|
| FILE: ./design/ironic_authentication.md
|
| 4 links checked.
|
| FILE: ./design/bare-metal-style-guide.md
|
| 0 links checked.
|
| FILE: ./design/sync-labels-bmh-to-node.md
| [✖] https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/0000-20170814-bounding-self-labeling-kubelets.md
|
| 3 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/0000-20170814-bounding-self-labeling-kubelets.md → Status: 404
|
| FILE: ./design/use-ironic.md
|
| 4 links checked.
|
| FILE: ./design/ironic-debuggability-improvement.md
| [✖] https://github.com/metal3-io/baremetal-operator/blob/main/ironic-deployment/ironic/ironic.yaml
|
| 5 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://github.com/metal3-io/baremetal-operator/blob/main/ironic-deployment/ironic/ironic.yaml → Status: 404
|
| FILE: ./design/hardware-classification-controller/expected-hardware-configuration-validation.md
| [✖] https://github.com/metal3-io/baremetal-operator/blob/main/deploy/crds/metal3.io_baremetalhosts_crd.yaml
|
| 4 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://github.com/metal3-io/baremetal-operator/blob/main/deploy/crds/metal3.io_baremetalhosts_crd.yaml → Status: 404
|
| FILE: ./design/hardware-classification-controller/support-for-new-parameters-hwcc-DiskAndNIC.md
|
| 4 links checked.
|
| FILE: ./design/hardware-classification-controller/support-for-error-count-parameter-hwcc.md
|
| 3 links checked.
|
| FILE: ./design/hardware-classification-controller/support-for-new-parameters-hwcc.md
|
| 4 links checked.
|
| FILE: ./design/reproducible-metal3-dev-env.md
|
| 2 links checked.
|
| FILE: ./design/cluster-api-provider-metal3/node_reuse.md
| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/capm3-remediation-controller-proposal.md
|
| 2 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/capm3-remediation-controller-proposal.md → Status: 404
|
| FILE: ./design/cluster-api-provider-metal3/capm3-remediation-controller-proposal.md
| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html
| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md
|
| 5 links checked.
|
| ERROR: 2 dead links found!
| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html → Status: 404
| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md → Status: 404
|
| FILE: ./design/cluster-api-provider-metal3/capm3-remediation-controller-improvement-proposal.md
|
| 7 links checked.
|
| FILE: ./design/cluster-api-provider-metal3/allow_disabling_node_disk_cleaning.md
|
| 5 links checked.
|
| FILE: ./design/community/foundation-proposal.md
| [✖] https://github.com/cncf/toc/blob/master/process/project_proposals.adoc
| [✖] https://github.com/cncf/toc/blob/master/process/graduation_criteria.adoc
|
| 8 links checked.
|
| ERROR: 2 dead links found!
| [✖] https://github.com/cncf/toc/blob/master/process/project_proposals.adoc → Status: 404
| [✖] https://github.com/cncf/toc/blob/master/process/graduation_criteria.adoc → Status: 404
|
| FILE: ./design/community/book-proposal.md
|
| 5 links checked.
|
| FILE: ./ADOPTERS.md
| [✖] https://www.ericsson.com/en/portfolio/digital-services/cloud-infrastructure/cloud-container-distribution
|
| 4 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://www.ericsson.com/en/portfolio/digital-services/cloud-infrastructure/cloud-container-distribution → Status: 403
|
| FILE: ./processes/managing-reviewers.md
|
| 3 links checked.
|
| FILE: ./processes/reviewer-permissions-migration.md
|
| 2 links checked.
|
| FILE: ./processes/roadmap.md
|
| 1 links checked.
|
| FILE: ./processes/triage.md
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Apriority%2Fawaiting-more-evidence
| [✖] https://github.com/issues?q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Alifecycle%2Fstale
|
| 3 links checked.
|
| ERROR: 3 dead links found!
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen → Status: 404
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Apriority%2Fawaiting-more-evidence → Status: 404
| [✖] https://github.com/issues?q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Alifecycle%2Fstale → Status: 404
|
| FILE: ./CONTRIBUTING.md
|
| 2 links checked.
|
| FILE: ./CODE_OF_CONDUCT.md
|
| 5 links checked.
|
| FILE: ./README.md
|
| 11 links checked.
|
| FILE: ./maintainers/README.md
|
| 0 links checked.
|
| FILE: ./crs_reference.md
| [✖] https://github.com/metal3-io/metal3-dev-env/tree/master/crs
|
| 3 links checked.
|
| ERROR: 1 dead links found!
| [✖] https://github.com/metal3-io/metal3-dev-env/tree/master/crs → Status: 404
|
Plenty of links to fix before this can be merged.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues close after 30d of inactivity. Reopen the issue with /reopen
. Mark the issue as fresh with /remove-lifecycle stale
.
/close
@metal3-io-bot: Closed this PR.
/reopen /remove-lifecycle stale
@tuminoid: Reopened this PR.
This is still pending fixing currently broken links before it can be activated.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues close after 30d of inactivity. Reopen the issue with /reopen
. Mark the issue as fresh with /remove-lifecycle stale
.
/close
@metal3-io-bot: Closed this PR.
/remove-lifecycle stale
/reopen
@tuminoid: Reopened this PR.
/lifecycle frozen This is pending multiple fixing PRs before it can be merged, let's se it frozen to avoid going stale.
@tuminoid: The lifecycle/frozen
label cannot be applied to Pull Requests.
@tuminoid: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
spellcheck | e26170dc87b949ca4d9c0bfd3ec25849be2a82db | link | true | /test spellcheck |
shellcheck | e26170dc87b949ca4d9c0bfd3ec25849be2a82db | link | true | /test shellcheck |
Full PR test history. Your PR dashboard.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
/remove lifecycle-stale /lifecycle frozen
@tuminoid: The lifecycle/frozen
label cannot be applied to Pull Requests.
/remove-lifecycle stale Still pending fixes to broken links to be activated
This can be redone, if the broken links get eventually fixed. Closing for now.
/close
@tuminoid: Closed this PR.
Add broken link checker action from CAPM3.