Closed SafeEHA closed 1 year ago
Hi @SafeEHA. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Yes, I would do so now Thanks for your suggestion
Please I also noticed that 2.1 Install baremetal operator is not accessible Do you by chance know whats the issue?
Seems not squashed still. You can use git rebase -i
or just re-create the commit.
I might have to re-create the commit, for some reason I can't see my commit when I git rebase -i
but I can see others
I might have to re-create the commit, for some reason I can't see my commit when I
git rebase -i
but I can see others
git rebase -i HEAD~5
should include all your 4 commits, and you can squash them.
Thanks, @tuminoid
I had earlier done git rebase -i HEAD~3
but I didn't find my commits that day, so I resorted to creating a new PR
I also just tried HEAD~5 like you suggested but I couldn't find my commits still
Thanks, @tuminoid I had earlier done
git rebase -i HEAD~3
but I didn't find my commits that day, so I resorted to creating a new PRI also just tried HEAD~5 like you suggested but I couldn't find my commits still
Are you in correct branch then? Your PR is coming from your fork, branch patch-1
. It seems to have the 4 of your commits on top, so they should be visible in rebase if you have checked out the branch.
Under 4.1 Install cluster-api metal3 provider TODO returns an error when clicked so i found the correct link and updated it