metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

Updated TODO for Ironic installation #324

Closed SafeEHA closed 1 year ago

SafeEHA commented 1 year ago

Under 4.1 Install cluster-api metal3 provider TODO returns an error when clicked so i found the correct link and updated it

metal3-io-bot commented 1 year ago

Hi @SafeEHA. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[docs/user-guide/src/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SafeEHA commented 1 year ago

Yes, I would do so now Thanks for your suggestion

Please I also noticed that 2.1 Install baremetal operator is not accessible Do you by chance know whats the issue?

dtantsur commented 1 year ago

Seems not squashed still. You can use git rebase -i or just re-create the commit.

SafeEHA commented 1 year ago

I might have to re-create the commit, for some reason I can't see my commit when I git rebase -i but I can see others

tuminoid commented 1 year ago

I might have to re-create the commit, for some reason I can't see my commit when I git rebase -i but I can see others

git rebase -i HEAD~5 should include all your 4 commits, and you can squash them.

SafeEHA commented 1 year ago

Thanks, @tuminoid I had earlier done git rebase -i HEAD~3 but I didn't find my commits that day, so I resorted to creating a new PR

I also just tried HEAD~5 like you suggested but I couldn't find my commits still

tuminoid commented 1 year ago

Thanks, @tuminoid I had earlier done git rebase -i HEAD~3 but I didn't find my commits that day, so I resorted to creating a new PR

I also just tried HEAD~5 like you suggested but I couldn't find my commits still

Are you in correct branch then? Your PR is coming from your fork, branch patch-1. It seems to have the 4 of your commits on top, so they should be visible in rebase if you have checked out the branch.