metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

Broken links fix #326

Closed SafeEHA closed 1 year ago

SafeEHA commented 1 year ago

Under 4.1 Install cluster-api metal3 provider TODO returns an error when clicked so i found the correct link and updated it

In 4.3.1 Remediation, the links remediation and CAPI MHC were broken. I replaced them with this this page

metal3-io-bot commented 1 year ago

Hi @SafeEHA. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SafeEHA commented 1 year ago

Hello @furkatgofurov7 So I tried squashing the prev commits but it was proving a bit difficult, I then decided to create a new branch locally and made changes there, I hope this is fine?

cc @elfosardo

dtantsur commented 1 year ago

This PR involves 3 unrelated commits, why is that?

elfosardo commented 1 year ago

@SafeEHA I think you're applying your patch to a wrong commit or the rebase went somewhat wrong please fix it

SafeEHA commented 1 year ago

Hello @elfosardo @dtantsur I have removed the other commits, please review Can i delete the other PRs I created prior to this one?

SafeEHA commented 1 year ago

I have tried deleting the binary files locally but I can't seem to find them, please can you assist me on how to go about this @tuminoid I wanted to delete the files individually from GitHub but I doubt that would help much and would definitely be too messy

tuminoid commented 1 year ago

I have tried deleting the binary files locally but I can't seem to find them, please can you assist me on how to go about this @tuminoid I wanted to delete the files individually from GitHub but I doubt that would help much and would definitely be too messy

In your fork's patch3 branch, do git rm -f <path to binary file> for each file, and amend the commit with git commit -a --amend.

SafeEHA commented 1 year ago

I have successfully removed them...thanks @tuminoid

tuminoid commented 1 year ago

I have successfully removed them...thanks @tuminoid

Now squash the commits please, then we're good to merge.

metal3-io-bot commented 1 year ago

@SafeEHA: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[docs/user-guide/src/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SafeEHA commented 1 year ago

Hello @tuminoid Thank you so much for all your help I want to notify you that in trying to squash the commits I created a conflict and I can't seem to resolve it, also git rebase -i HEAD~3 currently in my local environment returns 7-8 other commits instead of the exact number I specify.

I am looking at creating a new PR, which meets all the requirements since I am aware of those now so hopefully the merge can be done today