metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
267 stars 112 forks source link

Fix Ironic installation link #327

Closed SafeEHA closed 1 year ago

SafeEHA commented 1 year ago

While trying to squash commits in #326, I ran into issues with git rebase in my local environment as I stated in the last comment I made in #326 before updating my fork

I also noticed that #323 has been merged so I only need this to be merged if there are no more issues.

Thank you

cc: @tuminoid @elfosardo

metal3-io-bot commented 1 year ago

Hi @SafeEHA. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 1 year ago

/ok-to-test

SafeEHA commented 1 year ago

Thanks @lentzi90 @tuminoid I have squashed the commits to one, I believe we can go ahead and merge now

SafeEHA commented 1 year ago

I would also like to add that the link you @lentzi90 suggested returned an error after I made the first commit so I had to revert to the initial link so we don't run into any more problems Thanks

lentzi90 commented 1 year ago

I would also like to add that the link you @lentzi90 suggested returned an error after I made the first commit so I had to revert to the initial link so we don't run into any more problems Thanks

Where did you see this error? I explicitly checked it in the preview generated by netlify and it worked great! :thinking:

tuminoid commented 1 year ago

/retitle Fix Ironic installation link

SafeEHA commented 1 year ago

I would also like to add that the link you @lentzi90 suggested returned an error after I made the first commit so I had to revert to the initial link so we don't run into any more problems Thanks

Where did you see this error? I explicitly checked it in the preview generated by netlify and it worked great! thinking

I saw the error when I checked here on github, not on the netlify preview... i have resolved it now with the relative link and it works so i believe this PR can be merged and closed.

Thanks

SafeEHA commented 1 year ago

Hello, please is there anything left for me to do that I missed?

tuminoid commented 1 year ago

Hello, please is there anything left for me to do that I missed?

It needs approval from one of the approvers in userguide OWNERS file. Unless some further edits are asked, no actions from you are required.

SafeEHA commented 1 year ago

I understand, Thanks @tuminoid

Hello @furkatgofurov7 Please can you approve this?

lentzi90 commented 1 year ago

Ah no approve rights here :slightly_frowning_face: Thanks for the contribution!

elfosardo commented 1 year ago

/approve

metal3-io-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/user-guide/src/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment