Closed Gutopro closed 9 months ago
Hi @Gutopro. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
hello @tuminoid I'm in a bit of confusion, I made an initial commit on the branch which I requested a pull from, after some time I fixed another link on the same branch and made a commit on it, now my confusion arose from my inability to create a new pull request, will both commits be tested and treated as a single pull request since they affect the same file and are on the same branch or is there something wrong I did or should do correctly? and also when merging should I use my main branch as the head or should I use the other branch I created? thank you!
hello @tuminoid I'm in a bit of confusion, I made an initial commit on the branch which I requested a pull from, after some time I fixed another link on the same branch and made a commit on it, now my confusion arose from my inability to create a new pull request, will both commits be tested and treated as a single pull request since they affect the same file and are on the same branch or is there something wrong I did or should do correctly? and also when merging should I use my main branch as the head or should I use the other branch I created? thank you!
Basically, you should create a new branch in your fork for each change, then they can be created as separate PRs. Same branch = same PR. However, since the URLs you're changing are in the same file, you can do it in one PR.
That said, you should squash the commits into one. Generally, the rule is one commit per PR. You also need to address all reviewer's questions. In this case, there is open question on one of the changes.
@tuminoid I just fixed the incorrect changes can you have a look at it and tell me what you think?
@tuminoid I just fixed the incorrect changes can you have a look at it and tell me what you think?
You have six commits in this PR that do and undo changes, squash them please.
@tuminoid I just fixed the incorrect changes can you have a look at it and tell me what you think?
You have six commits in this PR that do and undo changes, squash them please.
hello @tuminoid i've squashed the commits into one single commit. thank you and good morning
This PR should probably be better pointing at new page https://github.com/metal3-io/metal3-docs/pull/352 is creating/reorganizing.
/hold
This PR should probably be better pointing at new page #352 is creating/reorganizing.
/hold
thanks for that @tuminoid should I wait for his PR to be merged or can i link it directly to his already created page?
This PR should probably be better pointing at new page #352 is creating/reorganizing. /hold
thanks for that @tuminoid should I wait for his PR to be merged or can i link it directly to his already created page?
@tuminoid hello I have updated the link which points to #352 could you kindly review it? thank you
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kashifest
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm /assign @kashifest
Thanks for the contribution! May the next one be smoother :)
lol thanks @tuminoid i wouldn't be able to do it without you!
/hold cancel
A new link for an installation guide on baremetal operators which can be found here https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/bmo/install_baremetal_operator.md