search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

fix dead link with error code 404 #356

Closed Gutopro closed 1 month ago

Gutopro commented 9 months ago

new link provides documentation for security vulnerability of kubletes ability to self-label node, former link resulted in a dead end returning a 404-'page not found' error. @tuminoid could you please review this?

metal3-io-bot commented 9 months ago

Hi @Gutopro. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 9 months ago

/ok-to-test

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[design/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/design/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metal3-io-bot commented 5 months ago

@Gutopro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
shellcheck cef7b1e2b2ad4072b36a16836eecc8a42ff83790 link true /test shellcheck
spellcheck cef7b1e2b2ad4072b36a16836eecc8a42ff83790 link true /test spellcheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
metal3-io-bot commented 2 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Rozzii commented 1 month ago

/remove-lifecycle stale There is no activity on this ticket I will move it to frozen. /lifecycle frozen

metal3-io-bot commented 1 month ago

@Rozzii: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to [this](https://github.com/metal3-io/metal3-docs/pull/356#issuecomment-2095426968): >/remove-lifecycle stale >There is no activity on this ticket I will move it to frozen. >/lifecycle frozen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 1 month ago

/close

Superseded by #433

metal3-io-bot commented 1 month ago

@tuminoid: Closed this PR.

In response to [this](https://github.com/metal3-io/metal3-docs/pull/356#issuecomment-2126924851): >/close > >Superseded by #433 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.