search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
267 stars 112 forks source link

fix and simplify all-owners script #367

Closed tuminoid closed 10 months ago

tuminoid commented 10 months ago

Noticed with @kashifest in #366 that the script isn't working right. Fix and simplify the script.

  1. remove emeritus_approvers from the list, they're not active maintainers
  2. simplify the primary branch detection
  3. add new repo utility-images
  4. remove lower casing the github names, some have legit caps there like "Rozzii", added explicit sorting option to keep the sorting the same in Linux and Mac
kashifest commented 10 months ago

cc @Rozzii

metal3-io-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Rozzii commented 10 months ago

/lgtm