search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
276 stars 115 forks source link

bump shellcheck to v0.10.0 #391

Closed tuminoid closed 8 months ago

tuminoid commented 8 months ago

Shellcheck had its first release since 2022, so bump it.

tuminoid commented 8 months ago

/hold needs project-infra change as well.

metal3-io-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 8 months ago

/unhold Project-infra has gone in. /test shellcheck

metal3-io-bot commented 8 months ago

@smoshiur1237: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/metal3-docs/pull/391#pullrequestreview-1924887246): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.