metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
267 stars 112 forks source link

Fix the Getting Started Guide link in introduction to try it section #393

Closed NymanRobin closed 6 months ago

NymanRobin commented 6 months ago

Currently the Getting Started Guide link in introduction section gives page not found error.

I suspect this is supposed to take the user to the tryit section, so here is the link fix also changes from relaying on url to file link. Maybe the wording should be changed as this tutorial is in fact part of the user guide? :thinking:

However if this understanding is wrong please correct me :D

metal3-io-bot commented 6 months ago

Hi @NymanRobin. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tuminoid commented 6 months ago

/ok-to-test

tuminoid commented 6 months ago

Thanks for the fix! Would you mind fixing all of the references to the old try-it.html ? There are couple more instances in blog posts for example. They are left overs from somewhat recent restructuring.

NymanRobin commented 6 months ago

Hey! Sure, I can tackle those as well. I will change the scope of this PR to fix the try-it links.

EDIT: Seems the blog posts were in another repo will open a PR there as well

tuminoid commented 6 months ago

Hey! Sure, I can tackle those as well. ~I will change the scope of this PR to fix the try-it links.~

EDIT: Seems the blog posts were in another repo will open a PR there as well

You're right, they weren't in this one. Thanks!

/lgtm

kashifest commented 6 months ago

/approve

metal3-io-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/user-guide/src/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/OWNERS)~~ [kashifest] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment