search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

:book: Fix ironic installation with kustomize instruction #407

Closed mquhuy closed 2 months ago

mquhuy commented 2 months ago

Fix #298

mquhuy commented 2 months ago

The content looks good, but the lines are very long. I guess we don't enforce any line length here yet @tuminoid ? Could you anyway perhaps wrap the lines so it is easier to read the "code" @mquhuy ?

Thanks @lentzi90. I've updated it.

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/user-guide/src/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 2 months ago

The content looks good, but the lines are very long. I guess we don't enforce any line length here yet @tuminoid ? Could you anyway perhaps wrap the lines so it is easier to read the "code" @mquhuy ?

This repo has so much old documentation that I did not enforce it yet, need to fix a lot of docs for that. One day, one beautiful day it'll be done :smile: