search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

Remove extra OWNERS files and propose more reviewers in root OWNERS #410

Closed kashifest closed 2 months ago

kashifest commented 2 months ago

Theres no need to have these extra OWNERS files as the design directory has its own and it does not inherit parent OWNER file. Removing these reduces confusion.

Also proposing more reviewers in the root OWNERS and this list is inherited mainly from the deleted OWNERS file.

lentzi90 commented 2 months ago

I think we will need approval from someone in each of the removed files

kashifest commented 2 months ago

I think we will need approval from someone in each of the removed files

A couple of them have single entry who have left the project a while ago

kashifest commented 2 months ago

@digambar15 @ogelbukh if you are still around Metal3 please review this patch and leave an approve label if no objection with this.

kashifest commented 2 months ago

/cc @dtantsur @zaneb @furkatgofurov7

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/OWNERS)~~ [lentzi90] - ~~[design/hardware-classification-controller/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/design/hardware-classification-controller/OWNERS)~~ [Rozzii] - ~~[design/helm-charts/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/design/helm-charts/OWNERS)~~ [Rozzii] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment