search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

hack/tools: reduce required Go version #419

Closed dtantsur closed 1 month ago

dtantsur commented 1 month ago

1.22 is very new and is not yet available in most distributions. It seems that 1.21 works fine.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

dtantsur commented 1 month ago

See https://github.com/metal3-io/metal3-docs/pull/420

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 1 month ago

/hold This perhaps passed the tests since we have a GO_VERSION variable set in the netlify settings and the build used go 1.22.2 anyhow, I will remove it now. I am anyhow making this variable to be set via the config file here #421. Here is the build which passed for this test:

Screenshot 2024-05-06 at 12 32 16

kashifest commented 1 month ago

/hold cancel I have removed it from the settings, lets do a repush of this branch to see if the build is still happy.

kashifest commented 1 month ago

Build is happy /lgtm