search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
276 stars 115 forks source link

Fix dead links at nodes-machines-and-hosts.md #441

Open tuminoid opened 5 months ago

tuminoid commented 5 months ago 
| FILE: ./design/nodes-machines-and-hosts.md
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html
| 
| 8 links checked.
| 
| ERROR: 1 dead links found!
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html → Status: 404

/triage accepted /help /good-first-issue

Split from https://github.com/metal3-io/metal3-docs/issues/328

metal3-io-bot commented 5 months ago

@tuminoid: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/metal3-io/metal3-docs/issues/441): >``` >| FILE: ./design/nodes-machines-and-hosts.md >| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html >| >| 8 links checked. >| >| ERROR: 1 dead links found! >| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html → Status: 404 >``` > >/triage accepted >/help >/good-first-issue > >Split from https://github.com/metal3-io/metal3-docs/issues/328 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ayushrakesh commented 5 months ago

@tuminoid

| FILE: ./design/nodes-machines-and-hosts.md | [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html

Is this is the correct link? https://release-0-1.cluster-api.sigs.k8s.io/common_code/machine_controller.html

tuminoid commented 5 months ago

@tuminoid

| FILE: ./design/nodes-machines-and-hosts.md | [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html

Is this is the correct link? https://release-0-1.cluster-api.sigs.k8s.io/common_code/machine_controller.html

That probably point to the version we originally linked to, but the current version we should link to is at https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine

Do you agree @dtantsur ?

metal3-io-bot commented 2 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

tuminoid commented 2 months ago

/remove-lifecycle stale