search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

Fix dead links at capm3-remediation-controller-proposal.md #442

Closed tuminoid closed 3 days ago

tuminoid commented 2 weeks ago 
| FILE: ./design/cluster-api-provider-metal3/capm3-remediation-controller-proposal.md
| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html
| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md
| 
| 6 links checked.
| 
| ERROR: 2 dead links found!
| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html → Status: 404
| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md → Status: 404

/triage accepted /help /good-first-issue

Split from https://github.com/metal3-io/metal3-docs/issues/328

metal3-io-bot commented 2 weeks ago

@tuminoid: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/metal3-io/metal3-docs/issues/442): >``` >| FILE: ./design/cluster-api-provider-metal3/capm3-remediation-controller-proposal.md >| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html >| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md >| >| 6 links checked. >| >| ERROR: 2 dead links found! >| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html → Status: 404 >| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md → Status: 404 >``` > >/triage accepted >/help >/good-first-issue > >Split from https://github.com/metal3-io/metal3-docs/issues/328 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ayushrakesh commented 1 week ago

Hey @tuminoid , is the two links are now correct?

| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html https://cluster-api.sigs.k8s.io/tasks/automated-machine-management/healthchecking

| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/inspection-api.md

tuminoid commented 5 days ago

Hey @tuminoid , is the two links are now correct?

| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html https://cluster-api.sigs.k8s.io/tasks/automated-machine-management/healthchecking

This is correct. We can see with Wayback Machine they're talking about the same thing: https://web.archive.org/web/20220711120457/https://cluster-api.sigs.k8s.io/tasks/healthcheck.html

| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/inspection-api.md

Yes, that is correct as well.

Would you make a PR to fix these?

ayushrakesh commented 5 days ago

@tuminoid Yes, want to make a PR.

tuminoid commented 5 days ago

/assign @ayushrakesh

ayushrakesh commented 5 days ago

@tuminoid Please review my PR.