search

metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.
http://metal3.io
Apache License 2.0
263 stars 111 forks source link

Fix dead links at triage.md #445

Closed tuminoid closed 1 week ago

tuminoid commented 2 weeks ago 
| FILE: ./processes/triage.md
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Apriority%2Fawaiting-more-evidence
| [✖] https://github.com/issues?q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Alifecycle%2Fstale
| 
| 3 links checked.
| 
| ERROR: 3 dead links found!
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen → Status: 404
| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Apriority%2Fawaiting-more-evidence → Status: 404
| [✖] https://github.com/issues?q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Alifecycle%2Fstale → Status: 404
|

/triage accepted /help /good-first-issue

Split from https://github.com/metal3-io/metal3-docs/issues/328

metal3-io-bot commented 2 weeks ago

@tuminoid: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/metal3-io/metal3-docs/issues/445): >``` >| FILE: ./processes/triage.md >| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen >| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Apriority%2Fawaiting-more-evidence >| [✖] https://github.com/issues?q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Alifecycle%2Fstale >| >| 3 links checked. >| >| ERROR: 3 dead links found! >| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen → Status: 404 >| [✖] https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Apriority%2Fawaiting-more-evidence → Status: 404 >| [✖] https://github.com/issues?q=archived%3Afalse+user%3Ametal3-io+is%3Aissue+sort%3Acreated-asc+is%3Aopen+label%3Alifecycle%2Fstale → Status: 404 >| >``` > >/triage accepted >/help >/good-first-issue > >Split from https://github.com/metal3-io/metal3-docs/issues/328 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aditya7302 commented 1 week ago

@tuminoid These links are not giving status 404 on my browser. image image image

tuminoid commented 1 week ago

@tuminoid These links are not giving status 404 on my browser. ![image](https://private-user-

They are 404 when queried by a bot/command line tool, but not when queried with a browser.

curl "https://github.com/issues?utf8=%E2%9C%93&q=archived%3Afalse+user%3Ametal3-io+no%3Alabel+is%3Aissue+sort%3Acreated-asc+is%3Aopen"
Not Found

So to fix these, we need to fix config of the link checker to present itself as a legit user.

priyanshsao commented 1 week ago

can you tell me where is the link checker file located?

tuminoid commented 1 week ago

can you tell me where is the link checker file located?

It does not exist in this repository yet, as we need to fix these dead links before introducing it. Output is from running the https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/.github/workflows/lint-docs.yaml locally in this repo.

priyanshsao commented 1 week ago

/assign

tuminoid commented 1 week ago

/close

We will switch the link checker to a better one, and these false positives do not need fixing right now.

metal3-io-bot commented 1 week ago

@tuminoid: Closing this issue.

In response to [this](https://github.com/metal3-io/metal3-docs/issues/445#issuecomment-2180298173): >/close > >We will switch the link checker to a better one, and these false positives do not need fixing right now. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.