Open chibuikeIg opened 5 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @chibuikeIg. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Thanks for the PR! Please fix the DCO (sign-off the commit) and repush.
/ok-to-test /cc @kashifest
PTAL if the linking the last version of the CRS is the right link to replace the dead link, or was the content actually migrated elsewhere. /hold
PTAL if the linking the last version of the CRS is the right link to replace the dead link, or was the content actually migrated elsewhere.
I think it was migrated under the base
subdirectory, and indeed we should link to the most recent version.
I think this whole crs_reference.md file is obsolete, its still pointing to cluster-api-provider-baremetal! and v1a2 and v1a3 of apis, the crs are non existent in dev-env since I believe
We have two contradicting opinions it seems. It is the only file in the root of the repo and indeed looks obsolete, so insttead of fixing the link we could delete the whole file? @dtantsur @kashifest
PR needs rebase.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Which problem is this PR solving?
Closes issue: Fix dead links at crs_reference.md #446 Fixes: #446
Description of the changes
Changed from https://github.com/metal3-io/metal3-dev-env/tree/master/crs to https://github.com/metal3-io/metal3-dev-env/tree/b5a53ecf9576c6deab81f692733782d4c5e8091a/crs
How was this change tested?
Ensured the link works both on Browser and when clicked on the Doc.