Closed priyanshsao closed 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @priyanshsao. Thanks for your PR.
I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
so you are saying that i have to change the link checker config instead of changing the links.
so you are saying that i have to change the link checker config instead of changing the links.
Yes. If you click the links in your browser, they're fine. If you curl them (as bot would do), they would give 404.
As I'm new to open-source, could you please give me some advice on how to modify the link checker configuration?
As I'm new to open-source, could you please give me some advice on how to modify the link checker configuration?
It seems the author of the link checker action has created a better action, reducing number of the false positives (like this triage.md one) does not need fixing. So consider the triage.md issue closed.
Which issue(s) this PR fixes:
Fixes #445 There are three dead links in https://github.com/metal3-io/metal3-docs/blob/main/processes/triage.md which shows the error 404 - page not found.
Links :-