metal3-io / metal3-docs

Architecture documentation that describes the components being built under Metal³.

http://metal3.io

Apache License 2.0

276 stars 115 forks source link

Fix dead links at cap3-remidiation-controller.md #452

Closed ayushrakesh closed 5 months ago

ayushrakesh commented 5 months ago

capm3-remediation-controller-proposal.md

| [✖] https://cluster-api.sigs.k8s.io/tasks/healthcheck.html changed to https://cluster-api.sigs.k8s.io/tasks/automated-machine-management/healthchecking

| [✖] https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/re-introspection-interface.md changed to https://github.com/metal3-io/metal3-docs/blob/main/design/baremetal-operator/inspection-api.md

Fixes #442

metal3-io-bot commented 5 months ago

Hi @ayushrakesh. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dtantsur commented 5 months ago

/approve /ok-to-test

metal3-io-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[design/OWNERS](https://github.com/metal3-io/metal3-docs/blob/main/design/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

metal3-io-bot commented 5 months ago

@tuminoid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/metal3-docs/pull/452#pullrequestreview-2140663440): >/lgtm > >Thanks for the contribution! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tuminoid commented 5 months ago

/cc @kashifest