search

metal3-io / project-infra

Metal3 testing infrastructure configuration
https://prow.apps.test.metal3.io
Apache License 2.0
17 stars 20 forks source link

basic-checks image has no change history, is locally built and pushed etc #864

Closed tuminoid closed 1 month ago

tuminoid commented 1 month ago

basic-checks image has no change history, it is built and pushed locally etc. These workflow issues need to be gone.

Current workflow

  1. Notice issue in tests: https://github.com/metal3-io/baremetal-operator/pull/1977/files#diff-25e9c6800a800713f0b8f25b203c4f9186120896512a0f9f0dee725e372a5b17R3 (requires Go 1.22.7 while basic-checks has 1.22.4 since last build)
  2. See https://github.com/metal3-io/project-infra/blob/main/prow/container-images/basic-checks/Dockerfile has no tags pinned, so it is using whatever was availablea at time of build (issue!)
  3. Build it locally (issue!)
  4. Push it with write rights to Quay (issue!)
  5. It is tagged exactly the same, without PR history, without build history (issue!)

Wanted workflow

  1. Go version is pinned in Dockerfile (provides change history)
  2. Workflow builds the image when PR pushed (no local building, always right build)
  3. Workflow pushes the image (no local pushing, no individual write rights)
  4. We have proper history and method of changing the contents and versions
tuminoid commented 1 month ago

/kind bug

tuminoid commented 1 month ago

/triage accepted

tuminoid commented 1 month ago

/assign